Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request previewer not working with errors after loading #735

Closed
LukaszJaro opened this issue Nov 9, 2023 · 1 comment · Fixed by #738
Closed

Pull Request previewer not working with errors after loading #735

LukaszJaro opened this issue Nov 9, 2023 · 1 comment · Fixed by #738
Labels
Mission-critical [Priority] High [Type] Bug An existing feature does not function as intended

Comments

@LukaszJaro
Copy link

Hi,

I tried multiple different PRs and same result:

Warning: file_get_contents(/wordpress/playground-consts.json): Failed to open stream: No such file or directory in /wordpress/wp-config.php on line 2

Warning: foreach() argument must be of type array|object, null given in /wordpress/wp-config.php on line 3

Warning: Cannot modify header information - headers already sent by (output started at /wordpress/wp-config.php:2) in /wordpress/wp-includes/pluggable.php on line 1435

Warning: Cannot modify header information - headers already sent by (output started at /wordpress/wp-config.php:2) in /wordpress/wp-includes/pluggable.php on line 1438

image

Using this url https://playground.wordpress.net/wordpress.html
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Priority] High Mission-critical labels Nov 10, 2023
@adamziel
Copy link
Collaborator

Thank you for reporting @LukaszJaro!

A part of the issue was related to this issue and should get fixed on the next website deploy later today: #736

There's still the part where it issues a warning, let's fix that next.

We should add an E2E test to the GH repo to keep verifying this workflow.
adamziel added a commit that referenced this issue Nov 13, 2023
@adamziel
[Blueprints] Always virtualize the wp-config.php constants in the def…
58766a8 
…ineWpConfigConsts step

PR #343 added a "virtualize" option so Playground can define new PHP
constants without changing the WordPress files in the filesystem.

This is incredibly useful. At the same time, mixing defineWpConfigConst
calls with and without the "virtualize" option may lead to a situation
where some constants are lost or when Playground tries to load a non-existing
playground-consts.json file – see #735.

Since I can't think of a good rationale to keep the non-virtualized
version around, let's reduce complexity and always virtualize the constants.
The "virtualize" option will now be noop and is only kept to avoid
breaking Blueprint schema validation for existing apps.

Closes #735
@adamziel adamziel mentioned this issue Nov 13, 2023
Merged
adamziel added a commit that referenced this issue Nov 13, 2023
@adamziel
[Blueprints] Always virtualize the wp-config.php constants in the def…
85a8ef5 
…ineWpConfigConsts step (#738)

## Description

PR #343 added a "virtualize" option so Playground can define new PHP
constants without changing the WordPress files in the filesystem.

This is incredibly useful. At the same time, mixing defineWpConfigConst
calls with and without the "virtualize" option may lead to a situation
where some constants are lost or when Playground tries to load a
non-existing playground-consts.json file – see #735.

Since I can't think of a good rationale to keep the non-virtualized
version around, let's reduce complexity and always virtualize the
constants. The "virtualize" option will now be noop and is only kept to
avoid breaking Blueprint schema validation for existing apps.

## Testing instructions

* Confirm unit tests pass
* Confirm the [WordPress PR
previewer](http://localhost:5400/website-server/wordpress.html) loads
Pull Requests without triggering any warnings

## Follow-up work

* Adjust Blueprint schema validation to tolerate the `virtualize` option so we can remove it from the type
* Call this step `definePHPConsts` as there is nothing specific to `wp-config.php` in it

Closes #735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mission-critical [Priority] High [Type] Bug An existing feature does not function as intended
2 participants
@adamziel @LukaszJaro