Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Export changes to Github as PR not working #1296

Closed
beafialho opened this issue Apr 23, 2024 · 1 comment · Fixed by #1308
Closed

Bug: Export changes to Github as PR not working #1296

beafialho opened this issue Apr 23, 2024 · 1 comment · Fixed by #1308
Labels
[Aspect] Browser [Type] Bug An existing feature does not function as intended

Comments

@beafialho
Copy link

This happened to @henriqueiamarino and me. When we used WordPress Playground to make changes to a theme and export the changes to Github as a PR, instead of updating it, the PR deletes the theme.

@mikachan also experienced an issue There was an unexpected error (Object does not exist), please try again..

cc: @adamziel
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Aspect] Browser labels Apr 23, 2024
adamziel added a commit that referenced this issue Apr 23, 2024
@adamziel
GitHub: Don't delete all the files when exporting a theme
fdb4df7 
Fixes themes and plugins export that got affected by #1174:

* Uses the theme/plugin directory as the content root
* Uses the adjusted `fromPlaygroundRoot` value instead of the one coming
  from the form.

Closes #1296

 ## Testing instructions

* Import https://github.com/Automattic/themes/tree/trunk/foam from GitHub
and export it immediately. There should be no files changed in the PR.
* Confirm https://github.com/adamziel/playground-docs-workflow still
  works with this PR
@adamziel adamziel mentioned this issue Apr 23, 2024
Merged
adamziel added a commit that referenced this issue Apr 23, 2024
@adamziel
GitHub: Don't delete all the files when exporting a theme (#1308)
5ba6f48 
Fixes themes and plugins export that got affected by #1174:

* Uses the theme/plugin directory as the content root
* Uses the adjusted `fromPlaygroundRoot` value instead of the one coming
from the form.

Closes #1296

 ## Testing instructions

* Import https://github.com/Automattic/themes/tree/trunk/foam from
GitHub and export it immediately. There should be no files changed in
the PR.
* Confirm https://github.com/adamziel/playground-docs-workflow still
works with this PR
@adamziel
Copy link
Collaborator

Solved in #1308, deploying a new version now
@mikachan mikachan mentioned this issue Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Aspect] Browser [Type] Bug An existing feature does not function as intended
2 participants
@adamziel @beafialho