Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore React and ReactDOM umd builds #7021

Conversation

youknowriad
Copy link
Contributor

In 6.6 we tried moving away from the deprecated React UMD builds, the issue we faced is that there's a warning that is triggered on the console because we're not using a separate impact for createRoot. (SCRIPT_DEBUG true and npm run build)

Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".

This warning has been removed in React 19 though along with the removal of the UMD builds, so we should be able to revert this PR when we upgrade to React 19.

Trac ticket: https://core.trac.wordpress.org/ticket/61324

@youknowriad youknowriad self-assigned this Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, mamaduka.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Mamaduka
Copy link
Member

@youknowriad, can you share testing instructions for the core? From our Slack conversation, I remember that some changes were required for wp-env.

@youknowriad
Copy link
Contributor Author

Yes, so to reproduce the issue on core, you have to use the "build" folder in your environment so

  • in .env file, you can change the LOCAL_DIR to build instead of src
  • run npm run build
  • run npm run env:start to launch the environment

you should be able to see the issue in trunk but not in this PR.

@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad deleted the update/restore-react-umd-builds branch July 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants