Restore React and ReactDOM umd builds #7021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6.6 we tried moving away from the deprecated React UMD builds, the issue we faced is that there's a warning that is triggered on the console because we're not using a separate impact for
createRoot
. (SCRIPT_DEBUG true andnpm run build
)Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".
This warning has been removed in React 19 though along with the removal of the UMD builds, so we should be able to revert this PR when we upgrade to React 19.
Trac ticket: https://core.trac.wordpress.org/ticket/61324