Add default return value to the WP_REST_Templates_Controller::get_wp_templates_author_text_field() method #7000
Conversation
…templates_author_text_field() method.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| @@ -865,6 +865,7 @@ private static function get_wp_templates_author_text_field( $template_object ) { | |||
| case 'site': | |||
| return get_bloginfo( 'name' ); | |||
| case 'user': | |||
| default: | |||
There was a problem hiding this comment.
I like the idea of making this code future-proof. But I'm thinking a better approach is to decouple the 2 methods.
How so?
Right now, get_wp_templates_original_source_field() returns one of the specific cases that are already covered here. What happens if that method gets changed, but changes are not reflected in this method?
I suggest instead of making the default use the user, instead, return an empty string at the end of the method. This return provides a graceful fallback or fallthrough.
return '';
What do you think @anton-vlasenko ?
There was a problem hiding this comment.
Well spotted, @hellofromtonya!
Thank you for the review.
Initially, I had the same idea but can't recall why I chose the other option.
Fixed in 96b5d55.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
|
Committed via https://core.trac.wordpress.org/changeset/58705. Thanks everyone for your contributions |
Thank you! |
Trac ticket: https://core.trac.wordpress.org/ticket/61580
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.