Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on 32282 #6875

Closed
wants to merge 2 commits into from
Closed

Run tests on 32282 #6875

wants to merge 2 commits into from

Conversation

joedolson
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/32282


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson
Copy link
Contributor Author

In r58456

@joedolson joedolson closed this Jun 21, 2024
@joedolson joedolson deleted the 32282 branch June 21, 2024 19:56
@kevin940726
Copy link
Member

Hi @joedolson!

Recently, after this PR (commit 25e7dc6 and 4f175e1), the e2e tests for image cropping in gutenberg started failing. I tested it manually and it seems like a legit bug. Here's a recording of the reproduction:

Kapture.2024-06-24.at.14.09.34.mp4

Testing instructions:

  1. Add an image block to a post and upload an image.
  2. Select "Crop" in the block toolbar.
  3. Select "Aspect ratio" in the block toolbar, then select an option from the dropdown list.
  4. Hit "Apply" in the block toolbar.
  5. Expect the image to be cropped, but it doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants