-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
60625 site icon UI #6871
base: trunk
Are you sure you want to change the base?
60625 site icon UI #6871
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@mukeshpanchal27, whats your opinion, should we remove both these assets: |
I'd like to suggest to take the opportunity of this PR to chamge a couple translatable strings, specifically the ones that use th the recommended size with this pattern: |
A few minor things: In the media modal dialog preview; The preview shows the app icon first and the browser icon last. However, the description The customizer media control shows the Remove button first and the Change image button last: While in the Settings page the order is different: If possible, I would use the same order everywhere. Not sure if that would impact all the customizer media controsl though. Noting that also the description placement in the customizer is different but I'm not sure that can be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an accessibility perspective everything looks good to me, thanks!
I quickly tested the functionality and didn't notice any issue
I left some minor notes. I'll leave a more complete code review to someone else more familiar than me with the customizer.
Great feedback, changed that.
The site logo controller in the customizer share the same pattern as site icon controller. So i think thats a separate ticket.
That can be changed, which the screenshot shows, and I removed the long italic style, plus changed to 512 by 512 in the description. |
Good catch, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few notes, mainly questions about escaping rules within style tags.
The new design looks really nice, thanks.
Thanks for taking the time for testing and reviewing @peterwilsoncc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for your work on this.
I've added one final note which I'll commit in a moment.
While looking at @jameskoster original comment i notices the suggestion to make the colors to CSS-vars. Latest commit implements that. The commit also takes advantage of the CSS vars, and implements a dark mode style. See attached image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this, it's looking good. Thanks! The only thought I have is that it would be best to keep the 512 as unchangeable in the translation since it's not a value that can be changed in the code.
First run of updating the UI.
https://core.trac.wordpress.org/ticket/60625
Before
![60625-before](https://cdn.statically.io/img/private-user-images.githubusercontent.com/11491369/341734378-8b384eb4-439c-4bba-9f3a-90cfd134a759.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NzE5NDksIm5iZiI6MTcyMjk3MTY0OSwicGF0aCI6Ii8xMTQ5MTM2OS8zNDE3MzQzNzgtOGIzODRlYjQtNDM5Yy00YmJhLTlmM2EtOTBjZmQxMzRhNzU5LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA2VDE5MTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5YTJkM2IzMGU3NDVkZWI1NmE4OWQzNmE3YzEwNTY5NjI1Mzk1NzBmY2IzNzRkOGFiMDM5MTJkMDFmMWMzYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ORc1cacfJPNuOJF7UWTD03ZQe5LPJEHIrXJ9Sf6hPZ0)
After