-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global styles: block background UI controls #6836
Global styles: block background UI controls #6836
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Tests to come
output any background styles, even if there's no background image - this is so users can extend/overwrite theme.json styles
210feca
to
9b4a6eb
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @ramonjd 👍
✅ Theme.json defined background images display in editors and frontend
✅ Code changes match GB PR
Editor | Frontend |
---|---|
I left a few minor nits as inline comments.
Thanks for adding the Latest changes LGTM 🚀 |
I appreciate the quick review! |
Committed in r58797. |
Syncing source code changes from WordPress/gutenberg#60100
Enables background images for supported blocks in global styles.
Testing
This PR adds the backend functionality only, which means the editor UI isn't yet available.
To test, define some background images for blocks. Here's an example using some of the images in
src/wp-content/themes/twentytwentyfour/
Here is some test HTML to create a test post:
The editor and frontend should display the background images:
Trac ticket: https://core.trac.wordpress.org/ticket/61588
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.