-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent PHP warning in wp_style_loader_src()
#6653
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@@ -2049,7 +2049,7 @@ function wp_style_loader_src( $src, $handle ) { | |||
return preg_replace( '#^wp-admin/#', './', $src ); | |||
} | |||
|
|||
if ( 'colors' === $handle ) { | |||
if ( 'colors' === $handle && isset( $_wp_admin_css_colors ) && is_array( $_wp_admin_css_colors ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the isset
here ? Adding the is_array
check in the condition should be enough to avoid the warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible in some contexts that the variable has not been set, so checking if a non-existent variable is an array would throw an error (at least I expect it would).
Add checks to prevent PHP warning in contexts where
colors
dependency is printed orstyle_loader_src
is used where$_wp_admin_css_colors
is not defined or not an array.Trac ticket: https://core.trac.wordpress.org/ticket/61302#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.