Backport: Theme JSON Tests: Refactor base styles to a static variable #6603
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
I'm not sure there's much benefit to syncing this to core, because these tests really need a wider refactor. I proposed that in WordPress/gutenberg#60842 (feedback welcome!) and intend to work on it in the next weeks.
The fact that this PR already has conflicts after a few days of being open illustrates the problem - every time we make updates to theme.json styles, these test strings also need to be updated, and the updates inevitably conflict 😬
That said, I don't have anything against this going into core, and am happy to help out with reviewing/committing once conflicts are solved!
Edit: if we go forward with this it also needs a trac ticket.
|
Let's keep this for the end, when all the other backports touching these tests are in. |
|
Given #6734 removes base styles from all tests where they aren't relevant, is this change still needed? |
|
Yeah this isn't needed anymore |
Backports WordPress/gutenberg#58975 to core.
I haven't yet been able to run the tests to check it works.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.