Block API: Render alias block with canonical block class name #6582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket:
Consider the following markup:
The second social link has an alias
core/social-link/wordpress
which we need to render correctly on the frontend with the correct CSS class names.All
WP_Block_Type
's are registered under their canonical form, meaning aliases are not in the registry. So when we are rendering an alias block type we need to know what the alias is so we can generate the appropriate class names for it, for the above mark up this would be:wp-social-link wp-social-link-wordpress wp-block-social-link
.This PR uses a new utility function to check if the block name we are generating a class name for is a variation (e.g. has an alias) or not and if so we generate an additional CSS class for the canonical block name.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.