Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coding standard changes #6360

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

coding standard changes #6360

wants to merge 1 commit into from

Conversation

mujuonly
Copy link

@mujuonly mujuonly commented Apr 4, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/60921

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mujuonly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
mukeshpanchal27
mukeshpanchal27 reviewed Apr 4, 2024
View reviewed changes
src/wp-admin/includes/deprecated.php
@@ -703,7 +703,7 @@ function get_others_unpublished_posts( $user_id, $type = 'any' ) {
else
$type_sql = " ( post_status = 'draft' OR post_status = 'pending' ) ";

$dir = ( 'pending' == $type ) ? 'ASC' : 'DESC';
$dir = ( 'pending' === $type ) ? 'ASC' : 'DESC';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$dir = ( 'pending' === $type ) ? 'ASC' : 'DESC';
$dir = 'pending' === $type ? 'ASC' : 'DESC';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the parentheses. Operator precedence can cause havoc, so preventing issues with that by using parentheses is always a good thing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the parentheses. Operator precedence can cause havoc, so preventing issues with that by using parentheses is always a good thing.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@mujuonly @jrfnl @mukeshpanchal27 @shaonkabir8