Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate submenu item level in admin nav menu editor and customizer nav menu editor #6318

Closed
wants to merge 35 commits into from

Conversation

Rcreators
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/60673


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Mar 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rcreators, joedolson, afercia.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

adamziel added a commit to WordPress/wordpress-playground that referenced this pull request May 16, 2024
…e the original zip (#1412)

Fixes a regression introduced in
#1400 that caused
the original zip file to be deleted.

To test, confirm you can preview
WordPress/wordpress-develop#6318 on this branch.

Closes #1409
src/wp-admin/nav-menus.php Outdated Show resolved Hide resolved
src/wp-admin/nav-menus.php Outdated Show resolved Hide resolved
src/wp-admin/nav-menus.php Outdated Show resolved Hide resolved
@Rcreators
Copy link
Author

@afercia All changes have been amended.

Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

@Rcreators
Copy link
Author

Please see inline comments

All the requested changes are pushed.

@afercia
Copy link
Contributor

afercia commented Jun 3, 2024

Thanks for addressing the coding standards points I raised @Rcreators
I understand part of this PR is code copied from already existing code there's some more occurrences of missing spaces between parehthesis and single quote (' or ') that would be nice to fix if possible. Thanks!
Other than that, I would leave functional and final review to @joedolson

@joedolson
Copy link
Contributor

In r58306

@joedolson joedolson closed this Jun 3, 2024
@Rcreators Rcreators deleted the #60673 branch June 4, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants