Twenty Twenty (1.2) Horizontal menu - Submenu - #49950 #6150
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Update javascript code for issue with having multilevel submenu. Added event for out of focus by other events
There was a problem hiding this comment.
A number of style issues; I suggest reviewing the JavaScript Coding Standards: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/
But, more importantly, this doesn't work if there's more than one sub menu in the menu, so it'll a functional improvement there.
| if (isEscape) { | ||
| if(menu.querySelector('li.menu-item-has-children').classList.contains('focus')){ | ||
| menu.querySelector('li.focus.menu-item-has-children > a').focus(); | ||
| menu.querySelector('li.menu-item-has-children.focus > ul.sub-menu').style.display = 'none'; |
There was a problem hiding this comment.
For multi-level submenus, this will close all levels of menu instead of just the current level. It's more standard for esc to close just the current level of submenu, rather than all submenus. I think you'll want to use a selector to get just the parent menu item, rather than the all ancestor navigation items.
| if(menu.querySelector('li.menu-item-has-children').classList.contains('focus')){ | ||
| menu.querySelector('li.focus.menu-item-has-children > a').focus(); | ||
| menu.querySelector('li.menu-item-has-children.focus > ul.sub-menu').style.display = 'none'; | ||
| menu.querySelector('li.focus.menu-item-has-children').classList.remove('focus'); |
There was a problem hiding this comment.
You're selecting li.focus.menu-item-has-children quite a few times here; that could probably be a variable, to keep code simpler.
| function updateFocus() { | ||
| var self = this; | ||
|
|
||
| //Removing Display none from previous child menu |
There was a problem hiding this comment.
Make comments declarative. E.g. 'Remove display: none from previous child menu.'
| } | ||
| }); | ||
|
|
||
| // Add focus to current a tag parent li. |
There was a problem hiding this comment.
Better: // Set focus on current a element's parent li.
|
|
||
| // If pressed key is esc, remove focus class from main parent menu li. | ||
| if (isEscape) { | ||
| if(menu.querySelector('li.menu-item-has-children').classList.contains('focus')){ |
There was a problem hiding this comment.
This selector won't work if there's more than one submenu, because more than one menu parent will match. You'd need to either use querySelectorAll or use a parent selector. As is, this doesn't work when there's more than one menu.
abbing will open a sub-menu and the user can go through it. If the user presses the ESC key while the sub-menu is opened, it will close the submenu and the user can move to the next menu item. Also updated index.js as per slack discussion to make parent a focus when closing sub menu with esc.
Trac ticket: https://core.trac.wordpress.org/ticket/49950
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.