Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropping site icon should preserve attachment properties #6128

Closed
wants to merge 28 commits into from

Conversation

Rcreators
Copy link

As per the discussion over the ticket, Created the function wp_copy_parent_attachment_properties() in image.php file and called it in ajax-actions.php file.

Trac ticket: https://core.trac.wordpress.org/ticket/60524


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Extended create_attachment_object() function to copy original attachment title, desc, alt text and caption to new cropped site icon file as well.
Created a new copy attachment properties function in image.php file. Called it in ajax-actions.php file instead of long separate code for site-icon and default.
Copy link

github-actions bot commented Feb 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rcreators, joedolson, swissspidy, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Removed extra white space
Added missing variable
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Rcreators and others added 5 commits February 16, 2024 18:11
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Same issue with custom image header cropping. Updated custom image header class to use newly created function to copy parent attachment properties.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are minor changes, but I think making the $context var optional would be valuable.

src/wp-admin/includes/ajax-actions.php Show resolved Hide resolved
src/wp-admin/includes/image.php Show resolved Hide resolved
Rcreators and others added 3 commits March 1, 2024 13:42
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@joedolson
Copy link
Contributor

In r57755

@joedolson joedolson closed this Mar 2, 2024
@Rcreators Rcreators deleted the #60524 branch March 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants