-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/Test Tools: Update the version of Node.js used in the Codespace… #6125
Conversation
…s container. Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.
Hi @christian-dale! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Hi @christian-dale, Did you mean to close this out? I had this marked to circle back to, but noticed it's closed out now. |
Hello @desrosj, I apologize for the confusion here. I managed to make this commit to the «trunk» brach of my fork, so it seemed the easiest way to fix my repo was to delete it and make a new fork with correct branching. This seemed to have caused the pull-request to be closed, but it is still open for merging :) |
Thanks! I am not sure how to really test this without merging. It seems straightforward enough, though. So I've gone and committed it in https://core.trac.wordpress.org/changeset/57667. I tested, and it seems to work as expected. I'm curious, do you use Codespaces for We added support for Codespaces, but I have not seen anyone use it as their preferred tool. |
I just recently started contributing to the Wordpress codebase, so I thought the easiest way to start testing would be by using GitHub Codespaces. The build processed failed, and that's why this was my first commit. I can't say Github Codespaces is my preferred dev environment, but it very useful for quick prototyping. |
Great! Thanks for the context and the contribution! 😃 |
…s container.
Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.
Trac ticket: https://core.trac.wordpress.org/ticket/60555
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.