Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test Tools: Update the version of Node.js used in the Codespace… #6125

Closed
wants to merge 1 commit into from
Closed

Conversation

christian-dale
Copy link

…s container.

Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.

Trac ticket: https://core.trac.wordpress.org/ticket/60555


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…s container.

Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.
Copy link

Hi @christian-dale! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link

github-actions bot commented Feb 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props itschristiandale.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@christian-dale christian-dale closed this by deleting the head repository Feb 16, 2024
@desrosj
Copy link
Contributor

desrosj commented Feb 20, 2024

Hi @christian-dale,

Did you mean to close this out? I had this marked to circle back to, but noticed it's closed out now.

@christian-dale
Copy link
Author

Hello @desrosj,

I apologize for the confusion here. I managed to make this commit to the «trunk» brach of my fork, so it seemed the easiest way to fix my repo was to delete it and make a new fork with correct branching.

This seemed to have caused the pull-request to be closed, but it is still open for merging :)

@desrosj
Copy link
Contributor

desrosj commented Feb 20, 2024

Thanks! I am not sure how to really test this without merging. It seems straightforward enough, though. So I've gone and committed it in https://core.trac.wordpress.org/changeset/57667. I tested, and it seems to work as expected.

I'm curious, do you use Codespaces for wordpress-develop? And if so, how often, and what do you typically use it for?

We added support for Codespaces, but I have not seen anyone use it as their preferred tool.

@christian-dale
Copy link
Author

I just recently started contributing to the Wordpress codebase, so I thought the easiest way to start testing would be by using GitHub Codespaces. The build processed failed, and that's why this was my first commit.

I can't say Github Codespaces is my preferred dev environment, but it very useful for quick prototyping.

@desrosj
Copy link
Contributor

desrosj commented Feb 20, 2024

Great! Thanks for the context and the contribution! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants