Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles revisions Controller: return single revision only when it matches the parent id #6108

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Feb 14, 2024

Brings global styles revisions controller WP_REST_Global_Styles_Revisions_Controller in line with the changes from:

This change is required as WP_REST_Global_Styles_Revisions_Controller doesn't inherit WP_REST_Revisions_Controller... yet. See: #6105

Gutenberg PR: WordPress/gutenberg#59049

npm run test:php -- --filter WP_REST_Global_Styles_Revisions_Controller_Test

Trac ticket: https://core.trac.wordpress.org/ticket/59810

Copy link

github-actions bot commented Feb 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ramonopoly, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd
Copy link
Member Author

ramonjd commented Feb 14, 2024

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

ramonjd added a commit to WordPress/gutenberg that referenced this pull request Feb 15, 2024
ramonjd added a commit to WordPress/gutenberg that referenced this pull request Feb 15, 2024
…59049)

This is required to sync with WordPress/wordpress-develop#5655

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
…roller.php

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@ramonjd
Copy link
Member Author

ramonjd commented Jun 18, 2024

d1faee9 is committed so this PR is no longer required.

@ramonjd ramonjd closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants