-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default wp_global_styles #6106
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
For reference, the issue now is this PHP warning when accessing the REST API:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I believe possibly because the extended class sets that property access to private wordpress-develop/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php Line 25 in e9ab1c1
Exploring also in WordPress/gutenberg#58972 |
This fixes the e2e tests - 95db1e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing with Gutenberg Plugin active as per original bug report I could not reproduce the original error with these changes in this PR.
Reverting those changes manually sees the error re-appear.
I also ended up coming up with much the same fix on Gutenberg repo so I'm fairly confident this is good.
Now that global controller changes have been reverted, we need a new patch that reapply them. To that end, here is the original PR with a fix applied. Closing this PR in favour of this #6105 |
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.