Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP deprecation error in WP_Image_Editor crop (`Implicit conversion from float) #5968

Closed
wants to merge 3 commits into from

Conversation

nicomollet
Copy link

@nicomollet nicomollet commented Jan 29, 2024

This pull request removes the PHP deprecated errors (like Implicit conversion from float 1112.7466666666667 to int loses precision) in WP_Image_Editor_Imagick/WP_Image_Editor crop method.

While crop expects integers, integers are not always passed to it.
So the goal is to cast the params to cast (int) before passing them to the method.

Other usage of crop already have int params so only 2 occurrences were fixed.

Tested on:

  • PHP 8.1
  • PHP 8.0

How to reproduce the error:

  1. Go to /wp-admin/media-new.php and upload an image
  2. "Edit" the image
  3. Then do a crop with the mouse and "Apply crop"
  4. See the Implicit conversion from float in the debug log

Trac ticket:
https://core.trac.wordpress.org/ticket/59782

Copy link

Hi @nicomollet! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson
Copy link
Contributor

In r58457

@joedolson joedolson closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants