#60328 Deprecated parameter default value of unregister_setting() is … #5959
Conversation
|
Hi @gerardreches! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-includes/option.php
Outdated
| @@ -2841,7 +2841,7 @@ function unregister_setting( $option_group, $option_name, $deprecated = '' ) { | |||
| unset( $new_allowed_options[ $option_group ][ $pos ] ); | |||
| } | |||
|
|
|||
| if ( '' !== $deprecated ) { | |||
| if ( '' !== $deprecated $$ null !== $deprecated ) { | |||
There was a problem hiding this comment.
@audrasjb Whoops! Thanks for noticing that. I was wondering why didn't the tests pass 😅
…not correct type
Trac ticket: https://core.trac.wordpress.org/ticket/60328
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.