Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for attachment page redirects for visitor #5732

Conversation

laxmariappan
Copy link

@laxmariappan laxmariappan commented Dec 6, 2023

Trac ticket: 59866

This PR adds a test for checking the attachment page redirection to the attachment file for the visitors.

Props 👏 @chesio for the patch @mukeshpanchal27 PR review and @joppuyo @afercia @SergeyBiryukov

/**
* @ticket 59866
*/
public function test_canonical_attachment_page_redirect_with_option_disabled_for_visitors(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function test_canonical_attachment_page_redirect_with_option_disabled_for_visitors(){
public function test_canonical_attachment_page_redirect_with_option_disabled_for_visitors() {

Fix PHPCS issue

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laxmariappan laxmariappan marked this pull request as ready for review December 7, 2023 08:33
@peterwilsoncc
Copy link
Contributor

A follow up pull request based on this one was merged in r57310 / c5fff20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants