Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: theme twentynineteen button line-height #5431

Closed
wants to merge 3 commits into from
Closed

fix: theme twentynineteen button line-height #5431

wants to merge 3 commits into from

Conversation

fnpen
Copy link

@fnpen fnpen commented Oct 8, 2023 •
edited
Loading

I moved line-height default definition from .wp-block-button__link to .wp-block-button, as a result, it allowed for overriding by style and block editor.

Trac ticket: https://core.trac.wordpress.org/ticket/58443
@sabernhardt
Copy link

It is very late in this release cycle for revising style-editor.scss too, but could you set line-height: $font__line-height-heading; on .wp-block-button and remove the line-height from .wp-block-button__link there for consistency?
@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r57599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@fnpen @sabernhardt @SergeyBiryukov