Image caption shortcode parameter validation

[BrianHenryIE]

Refresh of #4939

In versions of PHP 7.0 and prior, if anything other than an array was passed into this function, it would be cast to an array at $attr['caption'] = trim( $matches[2] );

To maintain that behavior in newer versions of PHP, I added a type check that would explicitly perform this behavior.

• Added unit test
• Formatted existing patch (after @mukeshpanchal27 review)

Trac ticket: https://core.trac.wordpress.org/ticket/45929

[mukeshpanchal27]

Suggested change

	/**
	/*

Remove extra star from comment

[BrianHenryIE]

That is not suggested by WPCS.

A regex search of the WordPress core codebase for \/\*[^\*]*]\s*$ does not find any example of the suggestion already in use.

[mukeshpanchal27]

Check Multiline comment formate: https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#5-2-multi-line-comments

[BrianHenryIE]

Fixed now.

[swissspidy]

Such a check was once added in https://core.trac.wordpress.org/changeset/56488

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @piercema@montclair.edu.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: brianhenryie, mukesh27, swissspidy.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: piercema@montclair.edu.

Co-authored-by: BrianHenryIE <brianhenryie@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.