#57897: REST attachments controller: Handle terms on creation #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
| $request->set_param( 'categories', array( $category['term_id'] ) ); | ||
| $response = rest_get_server()->dispatch( $request ); | ||
| $attachment = $response->get_data(); | ||
| $this->assertSame( array( $category['term_id'] ), wp_list_pluck( wp_get_post_terms( $attachment['id'], 'category' ), 'term_id' ) ); |
There was a problem hiding this comment.
Suggested change
| $this->assertSame( array( $category['term_id'] ), wp_list_pluck( wp_get_post_terms( $attachment['id'], 'category' ), 'term_id' ) ); | |
| $term = wp_get_post_terms( $attachment['id'], 'category' ); | |
| $this->assertSame( $category['term_id'], $term[0]->term_id ); |
Simplified version.
mukeshpanchal27
requested review from
spacedmonkey,
swissspidy and
TimothyBJacobs
|
Thank you, @iamdharmesh, for the unit tests. They appear to be solid to me. Let's wait for feedback from some of the maintainers before marking it for commit. |
|
Committed in https://core.trac.wordpress.org/changeset/57380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds handle terms in the REST attachments controller to assign terms to the freshly created attachment.
Currently,
\WP_REST_Attachments_Controller::create_item()does not callparent::create_item(), thus it also doesn't call\WP_REST_Posts_Controller::handle_terms(). That means it's impossible to assign terms to the freshly uploaded attachment. As suggested in the ticket description, PR addshandle_terms()inWP_REST_Attachments_Controllerto fix this issue.Trac ticket: https://core.trac.wordpress.org/ticket/57897
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.