Add a notice if a theme is requested too early when previewing a theme #5182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
_doing_it_wrong
notice if a theme is requested too early when previewing a theme.Trac ticket: https://core.trac.wordpress.org/ticket/59000
Related: WordPress/gutenberg#53284
Why
This is a follow-up for #5107.
The approach in #5107, “running the filters later”, works in most cases. The one exception is the case when the site has a plugin that runs
stylesheet
ortemplates
beforepluggable.php
(which means a plugin is loaded beforeplugin_loaded
), AND when the plugin wants to show the previewing theme. In this case, it gets the active theme’s stylesheet (not the previewing theme), which may lead to inconsistency.For such a case, this PR adds a
_doing_it_wrong
notice if a theme is requested too early when previewing a theme.Testing
wp-content/plugins/sample-plugin/sample-plugin.php
on your site./wp-admin/themes.php
and click theLive Preview
button on any Block theme (e.g. Twenty Twenty-Two).debug.php
:Function get_stylesheet() was called <strong>incorrectly</strong>. Calling get_stylesheet() before pluggable.php has loaded can result in getting the current theme instead of the previewed theme. Please ensure that you are using these functions after the plugins_loaded action has fired if this is not intended.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.