Align separator to center when Align-center option is set in editor #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @aslamdoctor for the PR. Left some feedback other then it ready to go.
| @@ -726,6 +726,11 @@ | |||
| display: none; | |||
| } | |||
| } | |||
|
|
|||
| &.aligncenter{ | |||
There was a problem hiding this comment.
Suggested change
| &.aligncenter{ | |
| &.aligncenter { |
Add missing space.
| @include media(tablet) { | ||
| width: calc( 100% + #{$size__spacing-unit * 2} ); | ||
| max-width: calc( 100% + #{$size__spacing-unit * 2} ); | ||
| margin-left: -#{$size__spacing-unit}; | ||
| } | ||
| } | ||
| } | ||
|
|
|
@sabernhardt, could you please take a look when you have a moment? |
|
Thank you, @aslamdoctor, for the update. It seems that the commit at 59f4019 includes some unnecessary changes. Could you please remove them? |
aslamdoctor
force-pushed
the
ticket/59204
branch
from
59f4019
to
e3b7baf
Compare
Thanks for the heads-up. I have reverted those unnecessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: 59204
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.