Use Elvis operator (a ?: b) where possible to replace a ? a : b style of ternary expressions
#4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -702,7 +702,7 @@ function twentythirteen_get_link_url() { | |||
| $content = get_the_content(); | |||
| $has_url = get_url_in_content( $content ); | |||
|
|
|||
| return ( $has_url ) ? $has_url : apply_filters( 'the_permalink', get_permalink() ); | |||
| return ( $has_url ) ?: apply_filters( 'the_permalink', get_permalink() ); | |||
There was a problem hiding this comment.
Suggested change
| return ( $has_url ) ?: apply_filters( 'the_permalink', get_permalink() ); | |
| return $has_url ?: apply_filters( 'the_permalink', get_permalink() ); |
remove brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat big change, but a simple one at that.
Replaces
a ? a : bpatterns of ternary statements to use the Elvis operatora ?: b.Null coalescing operator (
??) was added in PHP 7.0, which WordPress now requires as the minimum version. However, to make this ticket focused and easier to review, this ticket only proposes the Elvis operator.On tainted lines, it follows WordPress CS to use uppercase constants (NULL instead of null, for example), and removes a few cases of unnecessary braces. Apart from them, the diff output should be quite minimal and straight forward.
Perhaps, the review will be easier with word-diff (
git show --word-diff), or on GitHub, where it highlights word diffs in the line-diff mode.Trac ticket: https://core.trac.wordpress.org/ticket/58948
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.