Replace php_sapi_name function with PHP_SAPI constant
#4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super-micro optimization that replaces `php_sapi_name` function call with PHP_SAPI constant. One fewer function call, although it would take millions of calls to have a meaningful difference.
Ayesh
force-pushed
the
php-optimizations/php-sapi-name-const
branch
from
e8bb423
to
8b819a1
Compare
jrfnl
reviewed
Jul 31, 2023
jrfnl
approved these changes
Jul 31, 2023
mukeshpanchal27
approved these changes
Aug 1, 2023
|
Thanks for the PR! Merged in r56346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super-micro optimization that replaces
php_sapi_namefunction call with PHP_SAPI constant. One fewer function call, although it would take millions of calls to have a meaningful difference.Trac ticket: https://core.trac.wordpress.org/ticket/58942
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.