Add unit tests for ticket #58392 #4580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audrasjb
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Everything looks good to me, except that we need a few docblocks in the provided unit tests.
You can take wpPublishPost as an example.
costdev
reviewed
Jun 8, 2023
costdev
requested changes
Jun 9, 2023
There was a problem hiding this comment.
Thanks for the updates @Hug0-Drelon! I've left some more thoughts in this review 🙂
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
|
Thanks for the insight @costdev! Nice to see how standardization is going 🙂 |
costdev
approved these changes
Jun 11, 2023
There was a problem hiding this comment.
Thanks for the updates @Hug0-Drelon! I think that's all from me on this one!
|
committed in https://core.trac.wordpress.org/changeset/56043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58392
This PR adds unit tests to the previously proposed diff.