Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed escaping issue #4427

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Fixed escaping issue #4427

wants to merge 3 commits into from

Conversation

dilipbheda
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/58251

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
@SergeyBiryukov
Copy link
Member

Thanks for the PR! Unless I'm missing something, I don't think casting $node->id to a string is needed here, it is documented as a string in all of the WP_Admin_Bar class methods and should not ever be anything else, so casting it to a string in this particular place would be confusing.
@dilipbheda
Copy link
Author

@SergeyBiryukov Thank you for the review, I've removed casting and now $node->id is only trimmed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@dilipbheda @SergeyBiryukov