Replace include_once with require_once in wp-includes/comment.php #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WordPress PHP coding standards recommend using require[_once] for unconditional includes rather than include[_once]. This is because if the file being included is not found, include[_once] will throw a warning but continue execution, potentially leading to other errors or security issues if the file is needed for the application. However, in the WordPress core file wp-includes/comment.php, on lines 3046 and 3047, the function pingback() includes two files using include_once. To ensure consistency with the WordPress coding standards and improve the security and stability of the code, I propose replacing include_once with require_once on these lines. I will create a pull request to the WordPress core repository with this change.
|
Thanks for the PR! Merged in r55641 as part of a few other similar changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WordPress PHP coding standards recommend using require[_once] for unconditional includes rather than include[_once]. This is because if the file being included is not found, include[_once] will throw a warning but continue execution, potentially leading to other errors or security issues if the file is needed for the application.
However, in the WordPress core file wp-includes/comment.php, on lines 3046 and 3047, the function pingback() includes two files using include_once. To ensure consistency with the WordPress coding standards and improve the security and stability of the code, I propose replacing include_once with require_once on these lines.
I will create a pull request to the WordPress core repository with this change.
Trac ticket: https://core.trac.wordpress.org/ticket/58046
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.