REST attachments controller: Fix issue where terms cannot be assigned… #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @tanjimTC! This change looks good, could you add unit tests demonstrating that we can create an attachment with terms? |
|
Let's add a unit test. |
spacedmonkey
reviewed
Jun 5, 2023
| @@ -188,6 +188,13 @@ public function create_item( $request ) { | |||
|
|
|||
| $request->set_param( 'context', 'edit' ); | |||
|
|
|||
| // Assign terms to the freshly uploaded attachment. | |||
|
|
|||
|
Committed in https://core.trac.wordpress.org/changeset/57380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where terms could not be assigned to newly uploaded attachments through the REST API, due to the
\WP_REST_Attachments_Controller::create_item()function not callingparent::create_item()and thus not calling\WP_REST_Posts_Controller::handle_terms(). This PR adds the necessary lines of code to callhandle_terms()increate_item(), allowing terms to be assigned to attachments through the REST API. The changes have been tested and work as expected.Trac ticket: https://core.trac.wordpress.org/ticket/57897