Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading #4185

Closed
wants to merge 1 commit into from
Closed

Skip loading #4185

wants to merge 1 commit into from

Conversation

spacedmonkey
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/57814

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@pento pento closed this Mar 8, 2023
@pento pento deleted the feature/skip-loading branch March 8, 2023 13:35
@felixarntz
Copy link
Member

This deserves a closer look per https://core.trac.wordpress.org/ticket/57814#comment:5.

@spacedmonkey Please see my ticket comment and the performance data. Can you investigate what is going on there and open a new follow up PR? There must be something after the template_include filter which together with this PR causes things to slow down. I think you're on the right track with this PR so far, but it appears that there is something else to it.

If we can avoid the regression in the wp-template metric, there's a chance that this can lead to a massive performance improvement for classic themes total load time.

@spacedmonkey
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants