Adding fix for REST_Block_Type_Controller_Test::test_get_item_invalid() #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellofromtonya
approved these changes
Feb 14, 2023
|
Committed via https://core.trac.wordpress.org/changeset/55342. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for
REST_Block_Type_Controller_Test::test_get_item_invalid()which was throwing a PHP warning due to an incorrect data type in the 'styles' property of theWP_Block_Type.This PR Fixes a PHP Warning in the test caused by the 'styles' property not being an array. The proposed fix sets the 'styles' property to an empty array().
Could you please review the changes and let me know if anything needs to be updated or changed? I would really appreciate your feedback.
Thank you for taking the time to review this.
Trac ticket: https://core.trac.wordpress.org/ticket/57706