Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev container config - Dev container fixes #4050

Conversation

samruddhikhandale
Copy link

Following up from #4031

Updates dev container config for local development with Dev Containers.

@samruddhikhandale samruddhikhandale changed the title changes works for local Feb 10, 2023
@devfle
Copy link

devfle commented Feb 12, 2023

Hi, first of all really cool that you made Wordpress compatible with GitHub CodeSpaces! I also tested it outside of this repository and it works in my repository too. I could see a small issue both here and on my machine, where this step seems to be executed too early:
https://github.com/WordPress/wordpress-develop/blob/trunk/.devcontainer/setup.sh#L18

Wordpress can't be installed via the CLI on my system because some files are still missing. If I build in a "sleep" it works. Otherwise I have to run the CLI command manually.

@samruddhikhandale
Copy link
Author

Wordpress can't be installed via the CLI on my system because some files are still missing. If I build in a "sleep" it works. Otherwise I have to run the CLI command manually.

Interesting, I have tested this in a Codespace and locally on my machine, however, this issue never reproduced for me.

@devfle Can you try switching the postCreateCommand in here to postStartCommand and see if it helps?

@devfle
Copy link

devfle commented Feb 14, 2023

Wordpress can't be installed via the CLI on my system because some files are still missing. If I build in a "sleep" it works. Otherwise I have to run the CLI command manually.

Interesting, I have tested this in a Codespace and locally on my machine, however, this issue never reproduced for me.

@devfle Can you try switching the postCreateCommand in here to postStartCommand and see if it helps?

changed it and removed the sleep and still getting the following wp cli Error: "This does not seem to be a WordPress installation." Because some WP Files are missing.

@helen
Copy link
Member

helen commented Feb 16, 2023

Just gave this a go both in Codespaces and locally and it works beautifully! Going to commit so folks have it for WordCamp Asia's contributor day this weekend :)

@devfle Might help if you're able to share more of the creation log, I'm not getting that either so it's a bit hard to figure out which direction to go without more information since we're not able to reproduce yet.

@helen
Copy link
Member

helen commented Feb 16, 2023

@helen helen closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants