[WIP] Add devcontainer / Codespaces support #3670
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling over a PR I was originally noodling on here: helen#53
This works - you can spin up a new Codespace on this branch and after waiting patiently for the setup script to run (it's too quiet, you have to watch
setup.log
to check on progress), you should be able to go to the preview URL and log in and everything. A 2-core works fine, 4-core is quite speedy but of course uses double the core hours.However, I don't think this is ready to go into core :) I don't think it needs to be perfect but it feels a little weird to use the Docker-published
wordpress
image, and there are some details in here that don't feel right either.Here are the lingering todo items I currently have:
www-data
user?/wp-admin
kicks me tohttps://localhost/wp-admin
- no idea why, going towp-login.php
works fine, maybe something in the container somewhereTrac ticket: https://core.trac.wordpress.org/ticket/57187#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.