Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add devcontainer / Codespaces support #3670

Closed
wants to merge 14 commits into from

Conversation

helen
Copy link
Member

@helen helen commented Nov 23, 2022

Pulling over a PR I was originally noodling on here: helen#53

This works - you can spin up a new Codespace on this branch and after waiting patiently for the setup script to run (it's too quiet, you have to watch setup.log to check on progress), you should be able to go to the preview URL and log in and everything. A 2-core works fine, 4-core is quite speedy but of course uses double the core hours.

However, I don't think this is ready to go into core :) I don't think it needs to be perfect but it feels a little weird to use the Docker-published wordpress image, and there are some details in here that don't feel right either.

Here are the lingering todo items I currently have:

  • Do we actually need to be using the www-data user?
  • Can we use the same containers that wp env uses?
  • Allow some output to the terminal so it's clear what's happening
  • Sometimes navigating to /wp-admin kicks me to https://localhost/wp-admin - no idea why, going to wp-login.php works fine, maybe something in the container somewhere
  • How do tests run here? (Do they run, are they slow/fast/middling, etc.)

Trac ticket: https://core.trac.wordpress.org/ticket/57187#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@helen
Copy link
Member Author

helen commented Feb 9, 2023

Closing in favor of #4031

@helen helen closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant