Issue fixed for #57133 #3641
Closed
Issue fixed for #57133 #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your PR you can escape the $label variable also. |
hz-tyfoon
reviewed
Nov 17, 2022
src/wp-admin/user-new.php
Outdated
| @@ -443,7 +443,7 @@ | |||
| <table class="form-table" role="presentation"> | |||
| <tr class="form-field form-required"> | |||
| <th scope="row"><label for="adduser-email"><?php echo $label; ?></label></th> | |||
There was a problem hiding this comment.
Hey @monzuralam, your PR looks good to me.
Also, I think U can use esc_html for the $label just one line above ( line 445 )
There was a problem hiding this comment.
Hey @hz-tyfoon, Thanks bhaia.
The label escaping issue has been fixed.
|
Thanks for the PR! Merged in r54857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: [57133]
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.