url escaping issue solved for #57042 #3590
Conversation
|
Hi @monzuralam! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
| @@ -516,7 +516,7 @@ | |||
| printf( | |||
| /* translators: 1: Learn WordPress link. */ | |||
| __( 'Explore <a href="%s">learn.wordpress.org</a> for tutorial videos, online workshops, courses, and lesson plans for Meetup organizers, including new features in WordPress.' ), | |||
| 'https://learn.wordpress.org/' | |||
| esc_url( __( 'https://learn.wordpress.org/' ) ) | |||
There was a problem hiding this comment.
Is there any reason to make this link translatable?
There was a problem hiding this comment.
Thanks @audrasjb for the review.
I think it shouldn't be translatable. So don't think the __ should be used here.
There was a problem hiding this comment.
I thought '__' should be used because it was used here in the example of about.php
wordpress-develop/src/wp-admin/about.php
Line 219 in 3d54548
There was a problem hiding this comment.
To my knowledge, the Learn WordPress site is only available in the the default, en_US locale. I agree that there's no need to mark this string for translation (which eliminates the need to use esc_url() entirely) at this time.
There was a problem hiding this comment.
https://learn.wordpress.org/?locale=es_ES is available, for example, and might be why this is translatable. Would defer to @audrasjb, @SergeyBiryukov and others on this though.
There was a problem hiding this comment.
Ah! Thanks for finding that, I was trying es.learn.wordpress.org. The ticket attached to this PR has been closed, though, as the original intent was determined a wontfix. A new ticket to translate this URL (perhaps after confirmation from someone more familiar with translations) would be great!
|
Closing as the Trac ticket this was meant to address has been closed as |
Trac ticket: 57042
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.