Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Data Studio as trusted oEmbed provider #3227

Closed

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Sep 11, 2022

Adds oEmbed support for Google Data Studio.

Screenshot 2022-09-11 at 11 41 35

Screenshot 2022-09-11 at 11 40 46

Trac ticket: https://core.trac.wordpress.org/ticket/55771


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@helen
Copy link
Member

helen commented Sep 11, 2022

@helen helen closed this Sep 11, 2022
@swissspidy swissspidy deleted the add/55771-datastudio-oembed branch September 11, 2022 22:29
@@ -105,6 +105,7 @@ public function __construct() {
'#https?://([a-z]{2}|www)\.pinterest\.com(\.(au|mx))?/.*#i' => array( 'https://www.pinterest.com/oembed.json', true ),
'#https?://(www\.)?wolframcloud\.com/obj/.+#i' => array( 'https://www.wolframcloud.com/oembed', true ),
'#https?://pca\.st/.+#i' => array( 'https://pca.st/oembed.json', true ),
'#https?://datastudio\.google\.com/c/u/0/reporting/.+#i' => array( 'https://datastudio.google.com/oembed', true ),
Copy link
Contributor

@peterwilsoncc peterwilsoncc Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swissspidy I know this is late but it occurred to me while prepping the embed release notes that the /u/0/ section of the URL suggests the user URL rather than the sharing URL.

Signed in to a second account I see /u/1 in my URLs.

When I select to share a report I get a URL in the format https://datastudio.google.com/s/[A-Za-z0-9]+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We should improve the regex here then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants