-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PHP Notice when get_post_type_object() returns null in is_post_type_archive() #3027
Handle PHP Notice when get_post_type_object() returns null in is_post_type_archive() #3027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and unit tests! I've left some small change requests in this review.
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
@costdev Thanks for the review! Changes made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me provided manual testing works as expected. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Committed in https://core.trac.wordpress.org/changeset/54464 |
Trac ticket: https://core.trac.wordpress.org/ticket/56287
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.