Fix backward compatibility of get_term_feed_link() #1945
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Backward compatibility is broken since WordPress 5.9-alpha because
get_term_feed_link()
doesn't honor the$taxonomy
parameter anymore. Seewordpress-develop/src/wp-includes/link-template.php
Lines 925 to 926 in a848537
For instance, given a post tag term,
get_term_feed_link( $term_id, 'post_tag' )
returnsfalse
now.Changes
Don't use
category
as default taxonomy when passing a term ID.As the
WP_Term
object is retrieved later, use this to get the taxonomy.Trac ticket: https://core.trac.wordpress.org/ticket/50225