Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various PHP notices #1236

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix various PHP notices #1236

merged 3 commits into from
Jan 31, 2024

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Jan 31, 2024

  • Events: Check sort() argument type to avoid notice
  • Payments: Provide default value to avoid undefined notice
  • CampTix: Only variables should be passed by reference
  • CampTix: array_key_exists() expects a string
@iandunn
Events: Check sort() argument type to avoid notice
9bfc8f5 
Otherwise pentesters clutter the logs with notices from invalid data.
@iandunn iandunn self-assigned this Jan 31, 2024
@iandunn
Payments: Provide default value to avoid undefined notice
aa01849
@iandunn
CampTix: Fix various PHP notices
f05d434 
* Only variables should be passed by reference
* `array_key_exists()` expects a string
@iandunn iandunn marked this pull request as ready for review January 31, 2024 22:30
@iandunn iandunn merged commit fb79aa0 into production Jan 31, 2024
3 checks passed
@iandunn iandunn deleted the various-notices branch January 31, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@iandunn