Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Some missing translations enable #308

Closed
wants to merge 4 commits into from

Conversation

kamrulhasanj
Copy link
Contributor

Description
Some missing translations are enabled in TT4

@@ -58,7 +58,7 @@

<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">© 2024 Twenty Twenty Four</p>
<p class="has-small-font-size"><?php echo esc_html_x( '© 2024 Twenty Twenty Four', '', 'twentytwentyfour' ); ?></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use like that © 2024 Twenty Twenty-Four and give context

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twenty Twenty Four is probably something we don't want to translate. This string should be processed so the copyright year comes from a variable and not part of the translatable string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the site title block.

@@ -58,7 +58,7 @@

<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">© 2024 Twenty Twenty Four</p>
<p class="has-small-font-size"><?php echo esc_html_x( '© 2024 Twenty Twenty Four', '', 'twentytwentyfour' ); ?></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also follow the footer.php, and enable the translate
<p class="has-small-font-size">Designed with <a rel="nofollow" href="https://wordpress.org">WordPress</a></p>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off with the translations until all the patterns have been reviewed

@MaggieCabrera
Copy link
Collaborator

Closed in favor of #671

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants