-
Notifications
You must be signed in to change notification settings - Fork 117
Conversation
@@ -58,7 +58,7 @@ | |||
|
|||
<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} --> | |||
<div class="wp-block-group"><!-- wp:paragraph {"fontSize":"small"} --> | |||
<p class="has-small-font-size">© 2024 Twenty Twenty Four</p> | |||
<p class="has-small-font-size"><?php echo esc_html_x( '© 2024 Twenty Twenty Four', '', 'twentytwentyfour' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use like that © 2024 Twenty Twenty-Four
and give context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twenty Twenty Four is probably something we don't want to translate. This string should be processed so the copyright year comes from a variable and not part of the translatable string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be the site title block.
@@ -58,7 +58,7 @@ | |||
|
|||
<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between"}} --> | |||
<div class="wp-block-group"><!-- wp:paragraph {"fontSize":"small"} --> | |||
<p class="has-small-font-size">© 2024 Twenty Twenty Four</p> | |||
<p class="has-small-font-size"><?php echo esc_html_x( '© 2024 Twenty Twenty Four', '', 'twentytwentyfour' ); ?></p> | |||
<!-- /wp:paragraph --> | |||
|
|||
<!-- wp:paragraph {"fontSize":"small"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also follow the footer.php, and enable the translate
<p class="has-small-font-size">Designed with <a rel="nofollow" href="https://wordpress.org">WordPress</a></p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check these lines: https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/footer.php#L16-L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off with the translations until all the patterns have been reviewed
Closed in favor of #671 |
Description
Some missing translations are enabled in TT4