This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Left Aligned Call to Action with Image pattern adjustments #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
reviewed
Sep 13, 2023
patterns/left-aligned-cta-image.php
Outdated
| <div class="wp-block-columns alignfull"><!-- wp:column {"width":"642px","style":{"spacing":{"padding":{"top":"40px","right":"40px","bottom":"40px","left":"40px"}}}} --> | ||
| <!-- wp:group {"align":"wide","style":{"spacing":{"margin":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50"}}},"layout":{"type":"constrained","wideSize":"","contentSize":"1280px"}} --> | ||
| <div class="wp-block-group alignwide" style="margin-top:var(--wp--preset--spacing--50);margin-bottom:var(--wp--preset--spacing--50)"><!-- wp:columns {"align":"full"} --> | ||
| <div class="wp-block-columns alignfull"><!-- wp:column {"style":{"spacing":{"padding":{"top":"40px","right":"40px","bottom":"40px","left":"0px"}}}} --> | ||
| <div class="wp-block-column" style="padding-top:40px;padding-right:40px;padding-bottom:40px;padding-left:40px;flex-basis:642px"><!-- wp:heading --> |
There was a problem hiding this comment.
When I add the pattern I am getting a block validation error, because the padding-left and the flex basis are incorrect:
logger.js:17 Block validation: Block validation failed for `core/column` (Object).
Content generated by `save` function:
<div class="wp-block-column" style="padding-top:40px;padding-right:40px;padding-bottom:40px;padding-left:0px"></div>
Content retrieved from post body:
<div class="wp-block-column" style="padding-top:40px;padding-right:40px;padding-bottom:40px;padding-left:40px;flex-basis:642px">
</div>
(anonymous) @ logger.js:17
There was a problem hiding this comment.
Thanks for looking into it Carolina 😄 - I adjusted things to fix the issue.
|
Can you please rebase this and leave the changes to the checkmarks out of this PR? let's address that bit in #150 |
|
Sure, I was about to write the same thing. The goal of this PR was to cover #247 I'll rebase and leave the custom list styles implementation to Aurooba |
|
I made a comment on the other PR to make sure we remember to keep the visual adjustments for the new markup |
MaggieCabrera
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patterns tweaks from Beatriz.
Removed padding left from first column to match designs.
Fixes #247
Screenshots
Screen.Recording.2023-09-08.at.17.58.49.mov