Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Bring back translations to the pricing pattern #271

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 7, 2023

Description

  • Bring back translations to the pricing pattern.
@richtabor
Copy link
Member

Solid, but do want to note that there are still changes that may land. We're starting to get solid on the design system (esp if/when fluid type scale #268 lands). Mind taking a look at that?

@carolinan
Copy link
Contributor

carolinan commented Sep 7, 2023

I honestly don't understand why changes to the design system keeps removing the translations...
Example: Changing a size preset on a wrapping group block in a pattern should not change any text at all, only the small part of the pattern that needs to be changed, should be changed.

@richtabor
Copy link
Member

I honestly don't understand why changes to the design system keeps removing the translations...

Because we're not just changing one or two values; they are more substantial. So we're having to copy/paste the new pattern code into the PHP file, then add back all the translation functions. It's quite time-consuming and slows down the iterative process.

About half of the patterns are solid; will less possible changes — but the other half still need a good bit of re-working. If you look at the patterns in the library, you can tell them apart well.

@juanfra
Copy link
Member Author

juanfra commented Sep 8, 2023

Solid, but do want to note that there are still changes that may land. We're starting to get solid on the design system (esp if/when fluid type scale #268 lands). Mind taking a look at that?

Sure, will do 🎉

@carolinan carolinan merged commit 68a0a97 into trunk Sep 14, 2023
2 checks passed
@juanfra juanfra deleted the fix/pricing-pattern-translations branch September 14, 2023 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.