Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Block Patterns - Project Details #124

Closed
Tracked by #8
juanfra opened this issue Aug 28, 2023 · 6 comments
Closed
Tracked by #8

Block Patterns - Project Details #124

juanfra opened this issue Aug 28, 2023 · 6 comments

Comments

@juanfra
Copy link
Member

juanfra commented Aug 28, 2023

Description

🛠️ The goal of this issue is to track the implementation of the "Project Details" pattern.
🎨 Figma

Project Details

@juanfra juanfra mentioned this issue Aug 28, 2023
22 tasks
@juanfra juanfra changed the title Project Details Aug 28, 2023
@khleomix
Copy link
Contributor

I'm going to work on this.

@khleomix
Copy link
Contributor

khleomix commented Sep 4, 2023

@juanfra I've been trying to push my branch but I'm getting a permission error:

git push --set-upstream origin pattern/#124-Project-Details                    [23/09/4|11:01PM]
ERROR: Permission to WordPress/twentytwentyfour.git denied to khleomix.
fatal: Could not read from remote repository.
@MaggieCabrera
Copy link
Collaborator

@juanfra I've been trying to push my branch but I'm getting a permission error:

git push --set-upstream origin pattern/#124-Project-Details                    [23/09/4|11:01PM]
ERROR: Permission to WordPress/twentytwentyfour.git denied to khleomix.
fatal: Could not read from remote repository.

You need to make a fork of the repo to make your first PR first

@khleomix
Copy link
Contributor

khleomix commented Sep 4, 2023

Thanks @MaggieCabrera I'm on it.

khleomix added a commit to khleomix/twentytwentyfour that referenced this issue Sep 4, 2023
@khleomix
Copy link
Contributor

khleomix commented Sep 4, 2023

@MaggieCabrera I saw the markup you added in #188 would you want me to follow that markup for this pattern instead? Figma shows the heading as Extra Large but the preset is larger (3rem) than that of Figma which is 2.375rem (38px). The markup shows an extra empty column, do we need that and what's the expectation for that column? Allow people to add in additional content in between?

@MaggieCabrera
Copy link
Collaborator

@MaggieCabrera I saw the markup you added in #188 would you want me to follow that markup for this pattern instead?

Let's use it as a base, but we can iterate on it if need be

Figma shows the heading as Extra Large but the preset is larger (3rem) than that of Figma which is 2.375rem (38px).

Looking at the design for the overall pattern, the font sizes between three different templates need to be the same here to keep it consistent. Let's check the markup of the patterns that have been already created and make sure they are all the same. It looks like that is a big difference, so I would probably use a hardcoded value here

The markup shows an extra empty column, do we need that and what's the expectation for that column? Allow people to add in additional content in between?

I think this could be different ways of approaching this pattern. Which one looks better on mobile? As long as the end result looks like the design, I'm happy with some tweaks

khleomix added a commit to khleomix/twentytwentyfour that referenced this issue Sep 4, 2023
khleomix added a commit to khleomix/twentytwentyfour that referenced this issue Sep 4, 2023
MaggieCabrera added a commit that referenced this issue Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.