Install parent-theme-2021, which is required by translation events #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
psrpinto
changed the title
psrpinto
force-pushed
the
install-parent-theme-2021
branch
from
a17328b
to
5bb3a49
Compare
akirk
approved these changes
Jun 13, 2024
psrpinto
commented
Jun 14, 2024
| @@ -249,7 +249,7 @@ fi | |||
| # Enable the rosetta theme | |||
| # To see the available themes, execute: npm run wp-env run cli wp theme list | |||
| print_header "Enabling the wporg theme" | |||
| $WP_CLI_PREFIX wp theme activate pub $WP_CLI_SUFFIX | |||
| $WP_CLI_PREFIX wp theme activate pub/wporg $WP_CLI_SUFFIX | |||
There was a problem hiding this comment.
Oh, then this is a difference between LAMP and wp-env. Maybe we can get them the same via changing the mapping
There was a problem hiding this comment.
pub/wporg is closer to what the real WordPress.org structure is
There was a problem hiding this comment.
Ok, that makes sense, I'll look into it.
There was a problem hiding this comment.
I've pushed the necessary change, could you try if it still works in wp-env?
There was a problem hiding this comment.
I realized I had already merged it on Github, so I pushed the changes to the branch and re-merged it locally. So the change is already in main, committed via af0f924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the
pull_repos.shscript also pulls the wporg-parent-2021 theme, and theprovision.shscript links in underwp-content/themes.This theme is required by translation events. It is already present on the production environment.