Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update yoast/phpunit-polyfills requirement from ^1.0 to ^2.0 in /build-phpunit" #510

Conversation

mukeshpanchal27
Copy link
Member

Reverts #497

After the merge the unit tests goes failed so need some more debugging.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 8, 2024 09:45
Copy link

github-actions bot commented Jul 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

Confused, where are they failing? 🤔

@swissspidy
Copy link
Member

Ah, I see one failure now regarding the --verbose option which was removed in PHPUnit 10.

Let's just remove this argument then? 🤔

@mukeshpanchal27
Copy link
Member Author

I did that in local system and got similar error shown here https://github.com/WordPress/plugin-check/actions/runs/9837501136/job/27155469465?pr=512

@swissspidy
Copy link
Member

Yeah seeing it now too. Just strange that a PR like this one does not trigger unit tests, otherwise we would have caught this before merging.

@swissspidy swissspidy merged commit 89c3ed0 into trunk Jul 8, 2024
4 checks passed
@swissspidy swissspidy deleted the revert-497-dependabot/composer/build-phpunit/yoast/phpunit-polyfills-tw-2.0 branch July 8, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants