-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results from WPCLI that allows implement in w.org #480
base: trunk
Are you sure you want to change the base?
Results from WPCLI that allows implement in w.org #480
Conversation
As asked in #441 (comment)
|
I think is the easiest way. We have to be sure that errors haven't got any false positive. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidperezgar for the PR! Let some feedbacks other then it looks good to me.
- Fix
composer phpmd
errors.- Add
@SuppressWarnings(PHPMD.ExcessiveClassComplexity)
in classPlugin_Check_Command
docblock. - Add
@SuppressWarnings(PHPMD.CyclomaticComplexity)
incheck
method docblck.
- Add
- Additionally if you add Behat tests for new args then it would be great.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Thanks for your suggestions! |
I don't particularly like the approach of creating a new output format specific for wporg if we are instead able to consume one of the exiting formats when passing the correct arguments to the CLI script. Before trying to implement a solution here, can we get an answer from systems (e.g., @dd32) to the question asked in #441 (comment)? We also need to decide if #479 is a blocker to this issue, because we may not need a special CLI command at all if we can configure what errors are returned based on severity levels. |
….com:WordPress/plugin-check into 441-plugin-review-team-output-for-wporg-form
@davidperezgar I have fixed PHPMD issues and added behat test for new argument. |
I tried this command:
Argument |
Yes, and it's correct. The format for wporg is very strict and I shouldn't be customized. |
We need to give a result from WPCLI that fits meta team in order to execute this plugin in form submission.
This results fits the need asked by Meta #441 (comment), so we could implement as well as this #478 , and it would be the minimal needs to achieve that.
The results has a json format like this:
{"pass":true,"errors":[],"warnings":[]}
The Pass value is true if it has no errors.
I'd need some feedback if the approach is correct, or we could do something more.