Fix relative wp-env paths when host filepaths contain spaces #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the path passed to `wp-env` via the --env-cwd arg when `pwd` returns a file path containing a space. ## Testing instructions 1. Clone this repo to a folder locally that includes a space, like `~/Local Sites/plugin-check`. 2. Run a script like `npm run lint-php` and see that it's trying to run from `/var/www/html/wp-content/plugins/Local` 3. Check out this PR 4. Run the same script and see that it is running successful from `/var/www/html/wp-content/plugins/plugin-check`
|
This came up while helping @davidperezgar run PHPUnit tests locally, see #466 (comment) |
|
The Unit tests seem to be failing due to an old version of the wp-env package. I've raised a separate PR that should fix that issue here: #474. |
swissspidy
approved these changes
Jun 20, 2024
mukeshpanchal27
approved these changes
Jun 20, 2024
|
Thanks, all! |
|
Nice! thanks!!! |
|
That will prevent a lot of users having random problem when using unit tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the path passed to
wp-envvia the --env-cwd arg whenpwdreturns a file path containing a space.Testing instructions
~/Local Sites/plugin-check.npm run lint-phpand see that it's trying to run from/var/www/html/wp-content/plugins/Local/var/www/html/wp-content/plugins/plugin-check