Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum WP versions and WP version tested up to #1333

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

westonruter
Copy link
Member

In preparation for the WordPress 6.6 release, we need to update the Tested up to field to reflect 6.6. In the same way, we can now bump the Requires at least from 6.4 to 6.5. In addition to bumping these versions, this PR also removes obsolete code which was present exclusively for WP 6.4.

This cherry-picks some commits from #1302.

@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Jul 8, 2024
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -42,10 +42,10 @@ jobs:
fail-fast: false
matrix:
php: ['8.2', '8.1', '8.0', '7.4', '7.3', '7.2']
wp: [ 'latest' ]
wp: [ '6.6-RC2' ] # TODO: Change this back to latest.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll switch this back to latest once the 6.6 release is finalized. In the meantime, trunk is basically the same, so we're not hurting from not testing a WP version.

Comment on lines -150 to -172
/**
* Generates a user-level error/warning/notice/deprecation message.
*
* Generates the message when `WP_DEBUG` is true.
*
* @since 0.1.0
*
* @param string $function_name The function that triggered the error.
* @param string $message The message explaining the error.
* The message can contain allowed HTML 'a' (with href), 'code',
* 'br', 'em', and 'strong' tags and http or https protocols.
* If it contains other HTML tags or protocols, the message should be escaped
* before passing to this function to avoid being stripped {@see wp_kses()}.
* @param int $error_level Optional. The designated error type for this error.
* Only works with E_USER family of constants. Default E_USER_NOTICE.
*/
function embed_optimizer_trigger_error( string $function_name, string $message, int $error_level = E_USER_NOTICE ): void {
if ( ! function_exists( 'wp_trigger_error' ) ) {
return;
}
wp_trigger_error( $function_name, $message, $error_level );
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually WP 6.3-compat code, as wp_trigger_error() was introduced in 6.4.

@westonruter westonruter merged commit 35e682d into trunk Jul 8, 2024
21 checks passed
@westonruter westonruter deleted the bump/versions branch July 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
3 participants